From fe6320b468b1d2edc9cfb4ed60f975a4c1ff3e62 Mon Sep 17 00:00:00 2001 From: Kip Macy Date: Sat, 13 Dec 2008 20:18:05 +0000 Subject: [PATCH] radix node head lock needs to be held when calling rnh_addaddr --- sys/netinet/ip_fw2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/ip_fw2.c b/sys/netinet/ip_fw2.c index 826be2bdcfb..5d5da9f803d 100644 --- a/sys/netinet/ip_fw2.c +++ b/sys/netinet/ip_fw2.c @@ -1826,7 +1826,9 @@ add_table_entry(struct ip_fw_chain *ch, uint16_t tbl, in_addr_t addr, ent->mask.sin_addr.s_addr = htonl(mlen ? ~((1 << (32 - mlen)) - 1) : 0); ent->addr.sin_addr.s_addr = addr & ent->mask.sin_addr.s_addr; IPFW_WLOCK(ch); + RADIX_NODE_HEAD_LOCK(rnh); if (rnh->rnh_addaddr(&ent->addr, &ent->mask, rnh, (void *)ent) == + RADIX_NODE_HEAD_UNLOCK(rnh); NULL) { IPFW_WUNLOCK(ch); free(ent, M_IPFW_TBL);