From fc2749a40cd0814c89ca4e647c6797aec307d453 Mon Sep 17 00:00:00 2001 From: Robert Watson Date: Tue, 23 Oct 2001 19:09:01 +0000 Subject: [PATCH] o vn_open() fails to call VOP_CLOSE() if vfs_object_create fails. Ideally all successful calls to VOP_OPEN() might be reflected in a call to VOP_CLOSE(). For now, simply add a comment reflecting this problem; this should be fixed at some point. --- sys/kern/vfs_vnops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 911bd58602a..70d84a68059 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -188,6 +188,7 @@ restart: */ if (vn_canvmio(vp) == TRUE) { if ((error = vfs_object_create(vp, td, cred)) != 0) + /* XXX: Should VOP_CLOSE() again here. */ goto bad; }