upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm: Don't delete already deleted iicbus child from drm_iic_dp_aux

Browse source 
The iic_dp_aux_detach callback is therefore useless: it's replaced by
bus_generic_detach. This fixes a "General protection fault" panic during
second (incorrect) deletion of the child.

Tested by:	kwm@
Reviewed by:	ray@
This commit is contained in:
Jean-Sébastien Pédron 2013-08-24 23:54:06 +00:00
parent 285be846af
commit f7eda40d0e
1 changed files with 1 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
sys/dev/drm2/drm_dp_iic_helper.c
View file

@ -216,22 +216,6 @@ iic_dp_aux_attach(device_t idev)
return (0);
}
static int
iic_dp_aux_detach(device_t idev)
{
struct iic_dp_aux_data *aux_data;
device_t port;
aux_data = device_get_softc(idev);
port = aux_data->port;
bus_generic_detach(idev);
if (port != NULL)
device_delete_child(idev, port);
return (0);
}
int
iic_dp_aux_add_bus(device_t dev, const char *name,
int (*ch)(device_t idev, int mode, uint8_t write_byte, uint8_t *read_byte),
@ -277,7 +261,7 @@ iic_dp_aux_add_bus(device_t dev, const char *name,
static device_method_t drm_iic_dp_aux_methods[] = {
DEVMETHOD(device_probe, iic_dp_aux_probe),
DEVMETHOD(device_attach, iic_dp_aux_attach),
DEVMETHOD(device_detach, iic_dp_aux_detach),
DEVMETHOD(device_detach, bus_generic_detach),
DEVMETHOD(iicbus_reset, iic_dp_aux_reset),
DEVMETHOD(iicbus_transfer, iic_dp_aux_xfer),
DEVMETHOD_END