From f5bd8e9affdb04ec6ac7260b2a233f9e3e7b0557 Mon Sep 17 00:00:00 2001 From: Andre Oppermann Date: Tue, 2 Dec 2003 21:25:12 +0000 Subject: [PATCH] Swap destination and source arguments of two bcopy() calls. Before committing the initial tcp_hostcache I changed them from memcpy() to conform with FreeBSD style without realizing the difference in argument definition. This fixes hostcache operation for IPv6 (in general and explicitly IPv6 path mtu discovery) and T/TCP (RFC1644). Submitted by: Taku YAMAMOTO Approved by: re (rwatson) --- sys/netinet/tcp_hostcache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_hostcache.c b/sys/netinet/tcp_hostcache.c index 52f573f5bdc..ed7f9dadf9e 100644 --- a/sys/netinet/tcp_hostcache.c +++ b/sys/netinet/tcp_hostcache.c @@ -377,7 +377,7 @@ tcp_hc_insert(struct in_conninfo *inc) */ bzero(hc_entry, sizeof(*hc_entry)); if (inc->inc_isipv6) - bcopy(&hc_entry->ip6, &inc->inc6_faddr, sizeof(hc_entry->ip6)); + bcopy(&inc->inc6_faddr, &hc_entry->ip6, sizeof(hc_entry->ip6)); else hc_entry->ip4 = inc->inc_faddr; hc_entry->rmx_head = hc_head; @@ -474,7 +474,7 @@ tcp_hc_gettao(struct in_conninfo *inc, struct rmxp_tao *tao) hc_entry->rmx_hits++; hc_entry->rmx_expire = tcp_hostcache.expire; /* start over again */ - bcopy(tao, &hc_entry->rmx_tao, sizeof(*tao)); + bcopy(&hc_entry->rmx_tao, tao, sizeof(*tao)); THC_UNLOCK(&hc_entry->rmx_head->hch_mtx); }