upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 00:32:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ktrace: Remove CAPFAIL from default trace points

Browse source 
The CAPFAIL tracepoint was recently extended to report ECAPMODE
capability  violations for processes that do not enter capability mode.
This allows developers that are interested in Capsicumizing their
programs to determine where violations are being raised.

Previously, CAPFAIL only produced output for processes using Capsicum(4)
capabilties. Thus, most ktrace users never received log output from the
trace point. With the recent changes, this is no longer the case.

Having this trace point enabled by default will produce output for all
processes that use syscalls that are not permitted in capability mode.
This may lead to confusion for users that are not familiar with the
feature. Remove KTRFAC_CAPFAIL from ktrace's default points to avoid
this.

Approved by:	markj (mentor)
Reviewed by:	markj
MFC after:	1 month
Differential Revision:	https://reviews.freebsd.org/D44887
This commit is contained in:
Jake Freeland 2024-04-23 19:26:14 -05:00
parent 4f2ada0d88
commit f239db4800
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
usr.bin/ktrace/ktrace.1
View file

@ -137,7 +137,7 @@ trace
requests
.It Cm +
trace the default set of trace points -
.Cm c , i , n , p , s , t , u , y
.Cm c , i , n , s , t , u , y
.El
.It Ar command
Execute

7
usr.bin/ktrace/ktrace.h
View file

@ -31,13 +31,12 @@
#define DEF_POINTS (KTRFAC_SYSCALL | KTRFAC_SYSRET | KTRFAC_NAMEI | \
KTRFAC_GENIO | KTRFAC_PSIG | KTRFAC_USER | \
KTRFAC_STRUCT | KTRFAC_SYSCTL | KTRFAC_CAPFAIL | \
KTRFAC_STRUCT_ARRAY)
KTRFAC_STRUCT | KTRFAC_SYSCTL | KTRFAC_STRUCT_ARRAY)
#define PROC_ABI_POINTS (KTRFAC_PROCCTOR | KTRFAC_PROCDTOR)
#define ALL_POINTS (DEF_POINTS | KTRFAC_CSW | PROC_ABI_POINTS | \
KTRFAC_FAULT | KTRFAC_FAULTEND)
#define ALL_POINTS (DEF_POINTS | KTRFAC_CAPFAIL | KTRFAC_CSW | \
PROC_ABI_POINTS | KTRFAC_FAULT | KTRFAC_FAULTEND)
#define DEF_TRACEFILE "ktrace.out"