From eb6f5d6e72d3a5ec8dce8a1a91db46db288604b8 Mon Sep 17 00:00:00 2001 From: Navdeep Parhar Date: Tue, 21 Aug 2018 21:42:17 +0000 Subject: [PATCH] cxgbe(4): Make it clear that VI_INIT_DONE implies vi->ntxq > 0, and so rc will never be returned uninitialized. Reported by: Coverity (CID 1394884). This is a false positive though. Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_sched.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/cxgbe/t4_sched.c b/sys/dev/cxgbe/t4_sched.c index 029ff8de44e..1b7cc93b167 100644 --- a/sys/dev/cxgbe/t4_sched.c +++ b/sys/dev/cxgbe/t4_sched.c @@ -394,6 +394,7 @@ t4_set_sched_queue(struct adapter *sc, struct t4_sched_queue *p) /* Checking VI_INIT_DONE outside a synch-op is a harmless race here. */ if (!(vi->flags & VI_INIT_DONE)) return (EAGAIN); + MPASS(vi->ntxq > 0); if (!in_range(p->queue, 0, vi->ntxq - 1) || !in_range(p->cl, 0, sc->chip_params->nsched_cls - 1))