upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

NULL out ii->stdstart and ii->stdend when they are invalid. This

Browse source 
is not necessary for correct operation but makes it clearer that
freed transfer descriptors cannot be accessed.
This commit is contained in:
Ian Dowse 2006-05-28 01:17:13 +00:00
parent a7c15197cf
commit e97ba859b3
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sys/dev/usb/uhci.c
View file

@ -2690,6 +2690,8 @@ uhci_device_isoc_done(usbd_xfer_handle xfer)
return;
}
#endif
ii->stdstart = NULL;
ii->stdend = NULL;
}
void
@ -2748,8 +2750,11 @@ uhci_device_intr_done(usbd_xfer_handle xfer)
/* The ii is already on the examined list, just leave it. */
} else {
DPRINTFN(5,("uhci_device_intr_done: removing\n"));
if (uhci_active_intr_info(ii))
if (uhci_active_intr_info(ii)) {
uhci_del_intr_info(ii);
ii->stdstart = NULL;
ii->stdend = NULL;
}
}
}
@ -2778,6 +2783,8 @@ uhci_device_ctrl_done(usbd_xfer_handle xfer)
if (upipe->u.ctl.length != 0)
uhci_free_std_chain(sc, ii->stdstart->link.std, ii->stdend);
ii->stdstart = NULL;
ii->stdend = NULL;
DPRINTFN(5, ("uhci_device_ctrl_done: length=%d\n", xfer->actlen));
}
@ -2801,6 +2808,8 @@ uhci_device_bulk_done(usbd_xfer_handle xfer)
uhci_remove_bulk(sc, upipe->u.bulk.sqh);
uhci_free_std_chain(sc, ii->stdstart, NULL);
ii->stdstart = NULL;
ii->stdend = NULL;
DPRINTFN(5, ("uhci_device_bulk_done: length=%d\n", xfer->actlen));
}