upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-02-18 18:20:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod

Browse source 
The linuxkpi_gplv2.ko module on older-ish -CURRENT had absolutely no
.text contents, but it was still loaded.  Instead of hitting the later
assertion because 0 is not less than 0, we can just skip images like
this as we should not have any samples from them.

Reviewed by:	gallatin

(cherry picked from commit 77721403c91d67dbfd5a2c5c667e7f5d87acb3f6)
This commit is contained in:
Kyle Evans 2025-04-20 23:00:01 -05:00
parent 8dc42b80fd
commit e5a4712e65
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/libpmcstat/libpmcstat_image.c
View file

@ -194,6 +194,14 @@ pmcstat_image_link(struct pmcstat_process *pp, struct pmcstat_image *image,
assert(image->pi_type != PMCSTAT_IMAGE_UNKNOWN &&
image->pi_type != PMCSTAT_IMAGE_INDETERMINABLE);
/*
* It's possible to have images with nothing of value in .text
* legitimately. We shouldn't have any samples from this image, so
* don't bother with a map entry either.
*/
if (image->pi_start == 0 && image->pi_end == 0)
return;
if ((pcmnew = malloc(sizeof(*pcmnew))) == NULL)
err(EX_OSERR, "ERROR: Cannot create a map entry");