From e5a084d020da76d5d1220c658423284caf936dfe Mon Sep 17 00:00:00 2001 From: Gleb Smirnoff Date: Wed, 4 Dec 2019 22:41:52 +0000 Subject: [PATCH] Fix regression from r354484. Don't leak pcb lock if cr_canseeinpcb() returns non-zero. PR: 242415 --- sys/netinet/tcp_subr.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index 6a4051d3793..56b470c0aa0 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -2204,9 +2204,11 @@ tcp_pcblist(SYSCTL_HANDLER_ARGS) error = SYSCTL_OUT(req, &xt, sizeof xt); if (error) break; + else + continue; } - } else - INP_RUNLOCK(inp); + } + INP_RUNLOCK(inp); } NET_EPOCH_EXIT(et);