upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pkill tests: Fix pkill usage in the pkill -x test

Browse source 
The target process name(s) mark the beginning of the command's
positional parameters, so the -P filter wasn't getting applied as
intended.  As a result, the second "pkill -x sleep -P $$" would kill all
sleep(1) processes in the system, which can cause problems when running
tests in parallel.

MFC after:	2 weeks

(cherry picked from commit 57b09e470dbd84d1491a8972cf504b25e788a6c3)
This commit is contained in:
Mark Johnston 2025-03-15 07:12:45 -04:00
parent 48fddba637
commit e1a3b7ff9f
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
bin/pkill/tests/pkill-x_test.sh
View file

@ -9,13 +9,13 @@ sleep=$(pwd)/sleep.txt
ln -sf /bin/sleep $sleep
$sleep 5 &
sleep 0.3
pkill -x slee -P $$
pkill -P $$ -x slee
if [ $? -ne 0 ]; then
echo "ok 1 - $name"
else
echo "not ok 1 - $name"
fi
pkill -x sleep -P $$
pkill -P $$ -x sleep
if [ $? -eq 0 ]; then
echo "ok 2 - $name"
else
@ -28,13 +28,13 @@ sleep=$(pwd)/sleep.txt
ln -sf /bin/sleep $sleep
$sleep 5 &
sleep 0.3
pkill -x -f "$sleep " -P $$
pkill -P $$ -x -f "$sleep "
if [ $? -ne 0 ]; then
echo "ok 3 - $name"
else
echo "not ok 3 - $name"
fi
pkill -x -f "$sleep 5" -P $$
pkill -P $$ -x -f "$sleep 5"
if [ $? -eq 0 ]; then
echo "ok 4 - $name"
else