upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-13 18:50:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tcp rack: fix sendmap app limited count tracking

Browse source 
rc_app_limited_cnt is an internal counter on the rack structure
that tracks the number of sendmap entries that have the
RACK_APP_LIMITED flag set. These entries gate goodput measurements.
The counter is reported in a number of blackbox logging events.
When a sendmap entry which has the RACK_APP_LIMITED flag set is
cloned, the counter was not being maintained properly.
While here, cleanup the counter check when a sendmap entry with
the flag set is freed which previously hid this issue.

Reviewed by:	tuexen
MFC after:	1 week
Sponsored by:	Netflix, Inc.
This commit is contained in:
Peter Lei 2025-07-21 09:56:03 +02:00 committed by Michael Tuexen
parent 5f2ab75bcc
commit e0838f8a2e
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
sys/netinet/tcp_stacks/rack.c
View file

@ -3480,9 +3480,9 @@ static void
rack_free(struct tcp_rack *rack, struct rack_sendmap *rsm)
{
if (rsm->r_flags & RACK_APP_LIMITED) {
if (rack->r_ctl.rc_app_limited_cnt > 0) {
rack->r_ctl.rc_app_limited_cnt--;
}
KASSERT((rack->r_ctl.rc_app_limited_cnt > 0),
("app_cnt %u, rsm %p", rack->r_ctl.rc_app_limited_cnt, rsm));
rack->r_ctl.rc_app_limited_cnt--;
}
if (rsm->r_limit_type) {
/* currently there is only one limit type */
@ -7044,6 +7044,9 @@ rack_clone_rsm(struct tcp_rack *rack, struct rack_sendmap *nrsm,
/* Push bit must go to the right edge as well */
if (rsm->r_flags & RACK_HAD_PUSH)
rsm->r_flags &= ~RACK_HAD_PUSH;
/* Update the count if app limited */
if (nrsm->r_flags & RACK_APP_LIMITED)
rack->r_ctl.rc_app_limited_cnt++;
/* Clone over the state of the hw_tls flag */
nrsm->r_hw_tls = rsm->r_hw_tls;
/*