upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 08:43:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

sound tests: Fix 32bit calculation detection in pcm_read_write

Browse source 
Fix a mistake in the pcm_read_write test that would result in not
properly detecting 32bit calculation on 32bit architectures like i386.
As a consequence, the wrong values would be checked, thus failing the
test.

Reported by:	CI
Fixes:          27ef5d48c7 ("sound: Unit test the pcm sample read and write macros")
MFC after:      1 week
Reviewed by:    christos
Differential Revision:  https://reviews.freebsd.org/D48617
This commit is contained in:
Florian Walpen 2025-01-23 14:38:00 +02:00 committed by Christos Margiolis
parent c294ecb25b
commit e02b579b53
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/sys/sound/pcm_read_write.c
View file

@ -95,8 +95,14 @@ local_normalize(intpcm_t value, int val_bits, int norm_bits)
static intpcm_t
local_calc_limit(intpcm_t value, int val_bits)
{
/* Avoid implementation defined behavior. */
if (sizeof(intpcm32_t) == 32 && val_bits == 32)
/*
* When intpcm32_t is defined to be 32bit, calculations for mixing and
* volume changes use 32bit integers instead of 64bit. To get some
* headroom for calculations, 32bit sample values are restricted to
* 24bit magnitude in that case. Also avoid implementation defined
* behavior here.
*/
if (sizeof(intpcm32_t) == (32 / 8) && val_bits == 32)
/* Divide instead of right shift (value may be negative). */
return (value / (1 << 8));
return value;
@ -456,7 +462,7 @@ ATF_TC_BODY(pcm_write, tc)
}
local_pcm_write_calc(dst, value, test->format);
ATF_CHECK_MSG(memcmp(dst, expected, sizeof(dst)) == 0,
"pcm_write[\"%s\"].value: "
"pcm_write[\"%s\"].calc: "
"expected={0x%02x, 0x%02x, 0x%02x, 0x%02x}, "
"result={0x%02x, 0x%02x, 0x%02x, 0x%02x}, ", test->label,
expected[0], expected[1], expected[2], expected[3],