From dd70ad64bf8714ba3e6ce0df49ced3e58014cb67 Mon Sep 17 00:00:00 2001 From: Mikolaj Golub Date: Wed, 1 May 2013 15:02:58 +0000 Subject: [PATCH] procstat_getpathname: for kvm method, instead of returning the error that the method is not supported, return an empty string. This looks more handy for callers like procstat(1), which will not abort after the failed call and still output some useful information. MFC after: 3 weeks --- lib/libprocstat/libprocstat.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/libprocstat/libprocstat.c b/lib/libprocstat/libprocstat.c index 535cdfce39d..dd16c80d1c7 100644 --- a/lib/libprocstat/libprocstat.c +++ b/lib/libprocstat/libprocstat.c @@ -2114,8 +2114,10 @@ procstat_getpathname(struct procstat *procstat, struct kinfo_proc *kp, { switch(procstat->type) { case PROCSTAT_KVM: - warnx("kvm method is not supported"); - return (-1); + /* XXX: Return empty string. */ + if (maxlen > 0) + pathname[0] = '\0'; + return (0); case PROCSTAT_SYSCTL: return (procstat_getpathname_sysctl(kp->ki_pid, pathname, maxlen));