From dd697cbf6652199c2bd67b4345772b6955e986fb Mon Sep 17 00:00:00 2001 From: Jaakko Heinonen Date: Tue, 20 Oct 2009 15:06:18 +0000 Subject: [PATCH] Unloading of the nfscl module is unsupported because newnfslock doesn't support unloading. It's not trivial to implement newnfslock unloading so for now just admit that unloading is unsupported and refuse to attempt unload in all nfscl module event handlers. Reviewed by: rmacklem Approved by: trasz (mentor) --- sys/fs/nfsclient/nfs_clport.c | 7 +++++++ sys/fs/nfsclient/nfs_clsubs.c | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/sys/fs/nfsclient/nfs_clport.c b/sys/fs/nfsclient/nfs_clport.c index 39f2f02c96b..e81c3bf805b 100644 --- a/sys/fs/nfsclient/nfs_clport.c +++ b/sys/fs/nfsclient/nfs_clport.c @@ -1243,6 +1243,10 @@ nfscl_modevent(module_t mod, int type, void *data) break; } + /* + * XXX: Unloading of nfscl module is unsupported. + */ +#if 0 ncl_call_invalcaches = NULL; nfsd_call_nfscl = NULL; /* and get rid of the mutexes */ @@ -1250,6 +1254,9 @@ nfscl_modevent(module_t mod, int type, void *data) mtx_destroy(&ncl_iod_mutex); loaded = 0; break; +#else + /* FALLTHROUGH */ +#endif default: error = EOPNOTSUPP; break; diff --git a/sys/fs/nfsclient/nfs_clsubs.c b/sys/fs/nfsclient/nfs_clsubs.c index a217a21513a..3cd7e5c8685 100644 --- a/sys/fs/nfsclient/nfs_clsubs.c +++ b/sys/fs/nfsclient/nfs_clsubs.c @@ -87,6 +87,10 @@ extern struct nfsstats newnfsstats; int ncl_uninit(struct vfsconf *vfsp) { + /* + * XXX: Unloading of nfscl module is unsupported. + */ +#if 0 int i; /* @@ -104,6 +108,9 @@ ncl_uninit(struct vfsconf *vfsp) mtx_unlock(&ncl_iod_mutex); ncl_nhuninit(); return (0); +#else + return (EOPNOTSUPP); +#endif } void