upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 16:50:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Hyper-V: hn: rewrite hn rsc swtich to avoid sysctl hang

Browse source 
Changing the rsc_switch flag using sysctl to turn rsc on or off
could hang. The orignal code sends request to host to get the
mtu setting. Sometimes the host fails to reply, causing
the thread to sleep forever waiting for the host response.

Use existing cached mtu from hn device instead to avoid calling
host.

Reported by:	whu
Tested by:	whu
MFC after:	1 week
This commit is contained in:
Wei Hu 2025-02-04 13:39:14 +00:00
parent ff977fd34b
commit da1deb784d
1 changed files with 15 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
sys/dev/hyperv/netvsc/if_hn.c
View file

@ -2355,7 +2355,7 @@ hn_attach(device_t dev)
}
SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "rsc_switch",
CTLTYPE_UINT | CTLFLAG_RW, sc, 0, hn_rsc_sysctl, "A",
CTLTYPE_UINT | CTLFLAG_RW, sc, 0, hn_rsc_sysctl, "I",
"switch to rsc");
/*
@ -4523,24 +4523,22 @@ static int
hn_rsc_sysctl(SYSCTL_HANDLER_ARGS)
{
struct hn_softc *sc = arg1;
uint32_t mtu;
int rsc_ctrl, mtu;
int error;
HN_LOCK(sc);
error = hn_rndis_get_mtu(sc, &mtu);
if (error) {
if_printf(sc->hn_ifp, "failed to get mtu\n");
goto back;
}
error = SYSCTL_OUT(req, &(sc->hn_rsc_ctrl), sizeof(sc->hn_rsc_ctrl));
if (error || req->newptr == NULL)
goto back;
error = SYSCTL_IN(req, &(sc->hn_rsc_ctrl), sizeof(sc->hn_rsc_ctrl));
if (error)
goto back;
error = hn_rndis_reconf_offload(sc, mtu);
back:
HN_UNLOCK(sc);
rsc_ctrl = sc->hn_rsc_ctrl;
error = sysctl_handle_int(oidp, &rsc_ctrl, 0, req);
if (error || req->newptr == NULL)
return (error);
if (sc->hn_rsc_ctrl != rsc_ctrl) {
HN_LOCK(sc);
sc->hn_rsc_ctrl = rsc_ctrl;
mtu = if_getmtu(sc->hn_ifp);
error = hn_rndis_reconf_offload(sc, mtu);
HN_UNLOCK(sc);
}
return (error);
}
#ifndef RSS