From d681bc9e649a6077bd91be39174e40bc498e6dd7 Mon Sep 17 00:00:00 2001 From: Justin Hibbits Date: Tue, 24 Mar 2020 18:35:33 +0000 Subject: [PATCH] ismt: Fix ISMT_DESC_ADDR_RW macro, slave addresses are already left-shifted Reverts r293369. The macro was orginally correct, since our SMBus framework, unlike i2c, already requires addresses to be 8-bit, LSB-cleared. MFC after: 3 days Sponsored by: Juniper Networks, Inc --- sys/dev/ismt/ismt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ismt/ismt.c b/sys/dev/ismt/ismt.c index 88cdaac2dfd..4cdec469b63 100644 --- a/sys/dev/ismt/ismt.c +++ b/sys/dev/ismt/ismt.c @@ -72,7 +72,7 @@ __FBSDID("$FreeBSD$"); #define ISMT_DESC_LPR 0x80 /* Large Packet Received */ /* Macros */ -#define ISMT_DESC_ADDR_RW(addr, is_read) ((addr << 1) | (is_read)) +#define ISMT_DESC_ADDR_RW(addr, is_read) ((addr) | (is_read)) /* iSMT General Register address offsets (SMBBAR + ) */ #define ISMT_GR_GCTRL 0x000 /* General Control */