From d46c04051df81ab575e44a9d8e080f5d33b4270b Mon Sep 17 00:00:00 2001 From: Emmanuel Vadot Date: Mon, 30 Sep 2019 15:00:22 +0000 Subject: [PATCH] arm64: rockchip: correct reset value If bit is 0 the reset is not asserted. Also register our self as a reset provider, this was commented in r352850 Reported by: mmel --- sys/arm64/rockchip/clk/rk_cru.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sys/arm64/rockchip/clk/rk_cru.c b/sys/arm64/rockchip/clk/rk_cru.c index 99ed359ca6f..3a350f99715 100644 --- a/sys/arm64/rockchip/clk/rk_cru.c +++ b/sys/arm64/rockchip/clk/rk_cru.c @@ -155,7 +155,7 @@ rk_cru_reset_is_asserted(device_t dev, intptr_t id, bool *reset) val = CCU_READ4(sc, reg); mtx_unlock(&sc->mtx); - *reset = true; + *reset = false; if (val & (1 << bit)) *reset = true; @@ -265,9 +265,8 @@ rk_cru_attach(device_t dev) clk_set_assigned(dev, node); - /* If we have resets, register our self as a reset provider */ - /* if (sc->resets) */ - /* hwreset_register_ofw_provider(dev); */ + /* register our self as a reset provider */ + hwreset_register_ofw_provider(dev); return (0); }