From d1df7fdd040a25a6d61d04a3e04a931aa75f3094 Mon Sep 17 00:00:00 2001 From: Conrad Meyer Date: Sun, 19 Jan 2020 22:52:36 +0000 Subject: [PATCH] mps(4): add missing cam(4) dependency On a MINIMAL kernel, mps.ko wouldn't load because it uses the xpt_hold_boot symbol from CAM, but didn't have a dependency on cam(4). (CEM: Some context: when linking loaded modules, the kernel dynamic linker only looks for definitions in explictly marked dependency modules. Also, the identical mpr(4) driver uses the same CAM function, but already had the correct MODULE_DEPEND(), so no similar change is needed there.) Submitted by: Greg V Reviewed by: imp, myself Differential Revision: https://reviews.freebsd.org/D23272 --- sys/dev/mps/mps_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/mps/mps_pci.c b/sys/dev/mps/mps_pci.c index 1e12c9a6906..b1150828b95 100644 --- a/sys/dev/mps/mps_pci.c +++ b/sys/dev/mps/mps_pci.c @@ -145,6 +145,7 @@ struct mps_ident { static devclass_t mps_devclass; DRIVER_MODULE(mps, pci, mps_pci_driver, mps_devclass, 0, 0); +MODULE_DEPEND(mps, cam, 1, 1, 1); MODULE_PNP_INFO("U16:vendor;U16:device;U16:subvendor;U16:subdevice", pci, mps, mps_identifiers, nitems(mps_identifiers) - 1); static struct mps_ident *