upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 08:43:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ktls: Don't leak ktls session objects for certain errors.

Browse source 
ktls_cleanup() does not free ktls session objects, it merely
cleans (and frees) members of the object.

Change callers to use ktls_free() instead.

Reviewed by:	gallatin, markj
Sponsored by:	Chelsio Communications
Differential Revision:	https://reviews.freebsd.org/D37352
This commit is contained in:
John Baldwin 2022-11-11 16:00:37 -08:00
parent 573bd1fcf5
commit d01db2b837
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sys/kern/uipc_ktls.c
View file

@ -744,7 +744,7 @@ ktls_create_session(struct socket *so, struct tls_enable *en,
return (0);
out:
ktls_cleanup(tls);
ktls_free(tls);
return (error);
}
@ -1309,7 +1309,7 @@ ktls_enable_rx(struct socket *so, struct tls_enable *en)
error = ktls_ocf_try(so, tls, KTLS_RX);
if (error) {
ktls_cleanup(tls);
ktls_free(tls);
return (error);
}
@ -1387,13 +1387,13 @@ ktls_enable_tx(struct socket *so, struct tls_enable *en)
error = ktls_try_sw(so, tls, KTLS_TX);
if (error) {
ktls_cleanup(tls);
ktls_free(tls);
return (error);
}
error = SOCK_IO_SEND_LOCK(so, SBL_WAIT);
if (error) {
ktls_cleanup(tls);
ktls_free(tls);
return (error);
}