upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-08 16:22:46 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

vfs cache: denote a known bug in cache_remove_cnp

Browse source
This commit is contained in:
Mateusz Guzik 2023-10-05 12:32:29 +00:00
parent 0f15054f79
commit cd2105d691
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
sys/kern/vfs_cache.c
View file

@ -1822,6 +1822,15 @@ retry_dotdot:
return (1);
}
/*
* XXX note that access here is completely unlocked with no provisions
* to keep the hash allocated. If one is sufficiently unlucky a
* parallel cache resize can reallocate the hash, unmap backing pages
* and cause the empty check below to fault.
*
* Fixing this has epsilon priority, but can be done with no overhead
* for this codepath with sufficient effort.
*/
hash = cache_get_hash(cnp->cn_nameptr, cnp->cn_namelen, dvp);
blp = HASH2BUCKETLOCK(hash);
retry: