From ccd040ab18741cfde0a361b69427442fe934ebaa Mon Sep 17 00:00:00 2001 From: Andre Oppermann Date: Tue, 16 Jul 2013 16:37:08 +0000 Subject: [PATCH] Free the non-fatal "timestamp missing" debug string manually as it is not covered by the catch-all free for the error cases. Found by: Coverity --- sys/netinet/tcp_syncache.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index 71dfa9d5afc..cd7b424e0b1 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -1041,9 +1041,12 @@ syncache_expand(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, * reports of non-compliants stacks. */ if ((sc->sc_flags & SCF_TIMESTAMP) && !(to->to_flags & TOF_TS)) { - if ((s = tcp_log_addrs(inc, th, NULL, NULL))) + if ((s = tcp_log_addrs(inc, th, NULL, NULL))) { log(LOG_DEBUG, "%s; %s: Timestamp missing, " "no action\n", s, __func__); + free(s, M_TCPLOG); + s = NULL; + } } /*