upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

crypto: Fix assertions for digest-only sessions with separate output.

Browse source 
Digest-only sessions do not generate modified payload as an output, so
don't bother asserting anything about the payload with respect to the
output buffer other than the payload output start being zero.

In addition, a verify request on a digest-only session doesn't
generate any output at all so should never have a separate output
buffer.

PR:		252316
Reviewed by:	markj
Co-authored-by:	Jeremy Faulkner <gldisater@gmail.com>
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D35578
This commit is contained in:
John Baldwin 2022-06-30 10:10:00 -07:00
parent 0bd73da206
commit c71f2370c5
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys/opencrypto/crypto.c
View file

@ -1372,6 +1372,11 @@ crp_sanity(struct cryptop *crp)
if (out == NULL) {
KASSERT(crp->crp_payload_output_start == 0,
("payload output start non-zero without output buffer"));
} else if (csp->csp_mode == CSP_MODE_DIGEST) {
KASSERT(!(crp->crp_op & CRYPTO_OP_VERIFY_DIGEST),
("digest verify with separate output buffer"));
KASSERT(crp->crp_payload_output_start == 0,
("digest operation with non-zero payload output start"));
} else {
KASSERT(crp->crp_payload_output_start == 0 ||
crp->crp_payload_output_start < olen,