upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

bintrans: disable argument permutation for qp and base64

Browse source 
Err on the side of caution and revert to the BSD-style getopt(3)
behavior for argument processing, as it's harder to go back and it's
not clear that this was strictly intentional.

This is the difference between allowing `base64 /COPYRIGHT -w 80` and
forcing `base64 -w 80 /COPYRIGHT`.

Reviewed by:	emaste, pstef

(cherry picked from commit d8fd551438706b3766da23e72ef077945ba43cd3)
This commit is contained in:
Kyle Evans 2025-04-20 13:08:09 -05:00
parent 99509fcc87
commit c195ae9591
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
usr.bin/bintrans/bintrans.c
View file

@ -139,7 +139,7 @@ base64_encode_or_decode(int argc, char *argv[])
{NULL, no_argument, NULL, 0}
};
while ((ch = getopt_long(argc, argv, "diw:", opts, NULL)) != -1)
while ((ch = getopt_long(argc, argv, "+diw:", opts, NULL)) != -1)
switch (ch) {
case 'd':
decode = true;

2
usr.bin/bintrans/qp.c
View file

@ -181,7 +181,7 @@ main_quotedprintable(int argc, char *argv[])
{NULL, no_argument, NULL, 0}
};
while ((ch = getopt_long(argc, argv, "do:ru", opts, NULL)) != -1) {
while ((ch = getopt_long(argc, argv, "+do:ru", opts, NULL)) != -1) {
switch(ch) {
case 'o':
fpo = fopen(optarg, "w");