From bc97ba51001ddef32d8ac1e4d286f50c362956cb Mon Sep 17 00:00:00 2001 From: Julian Elischer Date: Wed, 19 Nov 2008 19:19:30 +0000 Subject: [PATCH] Fix a scope problem in the multiple routing table code that stopped the SO_SETFIB socket option from working correctly. Obtained from: Ironport MFC after: 3 days --- sys/kern/uipc_socket.c | 3 +++ sys/netinet/ip_divert.c | 1 + sys/netinet/ip_output.c | 9 ++++++++- sys/netinet/raw_ip.c | 8 +++++++- 4 files changed, 19 insertions(+), 2 deletions(-) diff --git a/sys/kern/uipc_socket.c b/sys/kern/uipc_socket.c index eb587fb56c3..e71250342ea 100644 --- a/sys/kern/uipc_socket.c +++ b/sys/kern/uipc_socket.c @@ -2218,6 +2218,9 @@ sosetopt(struct socket *so, struct sockopt *sopt) if ((so->so_proto->pr_domain->dom_family == PF_INET) || (so->so_proto->pr_domain->dom_family == PF_ROUTE)) { so->so_fibnum = optval; + /* Note: ignore error */ + if (so->so_proto && so->so_proto->pr_ctloutput) + (*so->so_proto->pr_ctloutput)(so, sopt); } else { so->so_fibnum = 0; } diff --git a/sys/netinet/ip_divert.c b/sys/netinet/ip_divert.c index dc000cbadb6..dd0445d9a7f 100644 --- a/sys/netinet/ip_divert.c +++ b/sys/netinet/ip_divert.c @@ -322,6 +322,7 @@ div_output(struct socket *so, struct mbuf *m, struct sockaddr_in *sin, */ m->m_pkthdr.rcvif = NULL; m->m_nextpkt = NULL; + M_SETFIB(m, so->so_fibnum); if (control) m_freem(control); /* XXX */ diff --git a/sys/netinet/ip_output.c b/sys/netinet/ip_output.c index 75ef09dd401..aa5d3e7140d 100644 --- a/sys/netinet/ip_output.c +++ b/sys/netinet/ip_output.c @@ -134,8 +134,10 @@ ip_output(struct mbuf *m, struct mbuf *opt, struct route *ro, int flags, bzero(ro, sizeof (*ro)); } - if (inp != NULL) + if (inp != NULL) { + M_SETFIB(m, inp->inp_inc.inc_fibnum); INP_LOCK_ASSERT(inp); + } if (opt) { len = 0; @@ -824,6 +826,11 @@ ip_ctloutput(struct socket *so, struct sockopt *sopt) error = optval = 0; if (sopt->sopt_level != IPPROTO_IP) { + if ((sopt->sopt_level == SOL_SOCKET) && + (sopt->sopt_name == SO_SETFIB)) { + inp->inp_inc.inc_fibnum = so->so_fibnum; + return (0); + } return (EINVAL); } diff --git a/sys/netinet/raw_ip.c b/sys/netinet/raw_ip.c index dfe902e31ad..a84db95ffc4 100644 --- a/sys/netinet/raw_ip.c +++ b/sys/netinet/raw_ip.c @@ -450,8 +450,14 @@ rip_ctloutput(struct socket *so, struct sockopt *sopt) struct inpcb *inp = sotoinpcb(so); int error, optval; - if (sopt->sopt_level != IPPROTO_IP) + if (sopt->sopt_level != IPPROTO_IP) { + if ((sopt->sopt_level == SOL_SOCKET) && + (sopt->sopt_name == SO_SETFIB)) { + inp->inp_inc.inc_fibnum = so->so_fibnum; + return (0); + } return (EINVAL); + } error = 0; switch (sopt->sopt_dir) {