upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-04 14:26:03 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcasper: Neuter false positive -Wuse-after-free warnings from GCC 13

Browse source 
GCC 13 incorrectly thinks a call to free after a failed realloc is a
use after free.

lib/libcasper/services/cap_grp/cap_grp.c: In function 'group_resize':
lib/libcasper/services/cap_grp/cap_grp.c:65:17: error: pointer 'buf' may be used after 'realloc' [-Werror=use-after-free]
   65 |                 free(buf);
      |                 ^~~~~~~~~
lib/libcasper/services/cap_grp/cap_grp.c:63:19: note: call to 'realloc' here
   63 |         gbuffer = realloc(buf, gbufsize);
      |                   ^~~~~~~~~~~~~~~~~~~~~~

Reviewed by:	imp, emaste
Differential Revision:	https://reviews.freebsd.org/D42576
This commit is contained in:
John Baldwin 2023-11-14 18:34:01 -08:00
parent b50261e21f
commit b7f7cc25c0
3 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/libcasper/services/cap_grp/Makefile
View file

@ -40,3 +40,6 @@ MLINKS+=cap_grp.3 cap_grp_limit_fields.3
MLINKS+=cap_grp.3 cap_grp_limit_groups.3
.include <bsd.lib.mk>
# GCC 13 complains incorrectly about free after failed realloc: GCC bug #110501
CFLAGS.cap_grp.c+= ${NO_WUSE_AFTER_FREE}

3
lib/libcasper/services/cap_netdb/Makefile
View file

@ -29,3 +29,6 @@ MLINKS+=cap_netdb.3 libcap_netdb.3
MLINKS+=cap_netdb.3 cap_getprotobyname.3
.include <bsd.lib.mk>
# GCC 13 complains incorrectly about free after failed realloc: GCC bug #110501
CFLAGS.cap_netdb.c+= ${NO_WUSE_AFTER_FREE}

3
lib/libcasper/services/cap_pwd/Makefile
View file

@ -40,3 +40,6 @@ MLINKS+=cap_pwd.3 cap_pwd_limit_fields.3
MLINKS+=cap_pwd.3 cap_pwd_limit_users.3
.include <bsd.lib.mk>
# GCC 13 complains incorrectly about free after failed realloc: GCC bug #110501
CFLAGS.cap_pwd.c+= ${NO_WUSE_AFTER_FREE}