From b6fab1eae2c2cfea6af09aadc8d97f25f9a2e023 Mon Sep 17 00:00:00 2001 From: Bruce Evans Date: Thu, 18 Sep 2003 07:01:30 +0000 Subject: [PATCH] Don't forget to reenable interrupts after a breakpoint and trace traps from user mode. This goes with rev.1.468 of machdep.c which changed the gates for these traps to interrupt gates. Having the interrupts disabled for these traps from user mode is just an unwanted side effect. This fixes at least 1 case of "panic: absolutely cannot call smp_ipi_shootdown with interrupts already disabled". Too much code was run with interrupts disabled, and it sometimes hit a sanity check. Fix verified by: deischen --- sys/i386/i386/trap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/i386/i386/trap.c b/sys/i386/i386/trap.c index d29c4cebc8f..ee9e6b9e1d0 100644 --- a/sys/i386/i386/trap.c +++ b/sys/i386/i386/trap.c @@ -274,6 +274,7 @@ trap(frame) case T_BPTFLT: /* bpt instruction fault */ case T_TRCTRAP: /* trace trap */ + enable_intr(); frame.tf_eflags &= ~PSL_T; i = SIGTRAP; break;