From b50a4dce185481bebf8096c27588ae04a4a2fd7c Mon Sep 17 00:00:00 2001 From: Lutz Donnerhacke Date: Sat, 3 Jul 2021 01:02:53 +0200 Subject: [PATCH] libalias: Avoid uninitialized expiration The expiration time of direct address mappings is explicitly uninitialized. Expire times are always compared during housekeeping. Despite the uninitialized value does not harm, it's simpler to just set it to a reasonable default. This was detected during valgrinding the test suite. MFC after: 3 days --- sys/netinet/libalias/alias_db.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/netinet/libalias/alias_db.c b/sys/netinet/libalias/alias_db.c index 19529271f49..9f8c6064d2a 100644 --- a/sys/netinet/libalias/alias_db.c +++ b/sys/netinet/libalias/alias_db.c @@ -613,8 +613,6 @@ AddLink(struct libalias *la, struct in_addr src_addr, struct in_addr dst_addr, case LINK_FRAGMENT_PTR: lnk->expire.time = FRAGMENT_PTR_EXPIRE_TIME; break; - case LINK_ADDR: - break; default: lnk->expire.time = PROTO_EXPIRE_TIME; break;