upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-10 17:22:46 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Type-o, change from[...] = 0 to fromb[...] = 0. The incorrect buffer

Browse source 
was having its last element zero'd.  It turns out not to be a security
    hole or to have any real effect on the code because 'from' was previously
    pointing to a buffer of the same size as 'fromb', and the last
    element in fromb is already 0 anyway due to the use of sizeof(fromb)-1
    in the strncpy() call.  But I'm not pressing my luck so only the type-o
    is being fixed.
This commit is contained in:
Matthew Dillon 2000-01-25 01:51:21 +00:00
parent 5bc2f0f789
commit b2dc65a8d3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
usr.sbin/lpr/lpd/lpd.c
View file

@ -590,7 +590,7 @@ chkhost(f)
inet_ntoa(f->sin_addr));
(void) strncpy(fromb, hp->h_name, sizeof(fromb) - 1);
from[sizeof(fromb) - 1] = '\0';
fromb[sizeof(fromb) - 1] = '\0';
from = fromb;
/* Check for spoof, ala rlogind */