upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ena: Extend debug prints for invalid req_id resets

Browse source 
Print information about qid if req_id is invalid. Add information about
qid and req_id if mbuf is invalid.

Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
This commit is contained in:
Dawid Gorecki 2022-06-10 11:18:07 +02:00 committed by Marcin Wojtas
parent d209ffee15
commit a9c39b031f
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sys/dev/ena/ena_datapath.c
View file

@ -212,7 +212,8 @@ ena_get_tx_req_id(struct ena_ring *tx_ring, struct ena_com_io_cq *io_cq,
return (EAGAIN);
if (unlikely(rc != 0)) {
ena_log(adapter->pdev, ERR, "Invalid req_id: %hu\n", *req_id);
ena_log(adapter->pdev, ERR, "Invalid req_id %hu in qid %hu\n",
*req_id, tx_ring->qid);
counter_u64_add(tx_ring->tx_stats.bad_req_id, 1);
goto err;
}
@ -220,7 +221,9 @@ ena_get_tx_req_id(struct ena_ring *tx_ring, struct ena_com_io_cq *io_cq,
if (tx_ring->tx_buffer_info[*req_id].mbuf != NULL)
return (0);
ena_log(adapter->pdev, ERR, "tx_info doesn't have valid mbuf\n");
ena_log(adapter->pdev, ERR,
"tx_info doesn't have valid mbuf. qid %hu req_id %hu\n",
tx_ring->qid, *req_id);
err:
ena_trigger_reset(adapter, ENA_REGS_RESET_INV_TX_REQ_ID);

3
sys/dev/ena/ena_netmap.c
View file

@ -882,7 +882,8 @@ validate_tx_req_id(struct ena_ring *tx_ring, uint16_t req_id)
if (likely(req_id < tx_ring->ring_size))
return (0);
ena_log_nm(adapter->pdev, WARN, "Invalid req_id: %hu\n", req_id);
ena_log_nm(adapter->pdev, WARN, "Invalid req_id %hu in qid %hu\n",
req_id, tx_ring->qid);
counter_u64_add(tx_ring->tx_stats.bad_req_id, 1);
ena_trigger_reset(adapter, ENA_REGS_RESET_INV_TX_REQ_ID);