upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-03-29 22:23:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

nfsd: Fix the NFSv4 pNFS MDS server for DS NFSERR_NOSPC

Browse source 
If a pNFS server's DS runs out of disk space, it replies
NFSERR_NOSPC to the client doing writing.  For the Linux
client, it then sends a LayoutError RPC to the server to
tell it about the error and keeps retrying, doing repeated
LayoutGet and Write RPCs to the DS.  The Linux client is
"stuck" until disk space on the DS is free'd up.
For a mirrored server configuration, the first mirror that
ran out of space was taken offline.  This does not make
much sense, since the other mirror(s) will run out of space
soon and the fix is a manual cleanup up disk space.

This patch changes the pNFS server to not disable a mirror
for the mirrored case when this occurs.

Further work is needed, since the Linux client expects the
MDS to reply NFSERR_NOSPC to LayoutGets once the DS is out
of space.  Without this further change, the above mentioned
looping occurs.

Found during a recent IEFT NFSv4 working group testing event.

MFC after:	2 weeks
This commit is contained in:
Rick Macklem 2021-11-07 11:43:03 -08:00
parent 597b026757
commit a7e014eee5
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sys/fs/nfsserver/nfs_nfsdserv.c
View file

@ -5046,10 +5046,11 @@ nfsrvd_layouterror(struct nfsrv_descript *nd, __unused int isdgram,
opnum = fxdr_unsigned(int, *tl);
NFSD_DEBUG(4, "nfsrvd_layouterr op=%d stat=%d\n", opnum, stat);
/*
* Except for NFSERR_ACCES and NFSERR_STALE errors,
* disable the mirror.
* Except for NFSERR_ACCES, NFSERR_STALE and NFSERR_NOSPC
* errors, disable the mirror.
*/
if (stat != NFSERR_ACCES && stat != NFSERR_STALE)
if (stat != NFSERR_ACCES && stat != NFSERR_STALE &&
stat != NFSERR_NOSPC)
nfsrv_delds(devid, curthread);
}
nfsmout:

7
sys/fs/nfsserver/nfs_nfsdstate.c
View file

@ -7009,10 +7009,11 @@ nfsrv_flexlayouterr(struct nfsrv_descript *nd, uint32_t *layp, int maxcnt,
NFSD_DEBUG(4, "flexlayouterr op=%d stat=%d\n", opnum,
stat);
/*
* Except for NFSERR_ACCES and NFSERR_STALE errors,
* disable the mirror.
* Except for NFSERR_ACCES, NFSERR_STALE and
* NFSERR_NOSPC errors, disable the mirror.
*/
if (stat != NFSERR_ACCES && stat != NFSERR_STALE)
if (stat != NFSERR_ACCES && stat != NFSERR_STALE &&
stat != NFSERR_NOSPC)
nfsrv_delds(devid, p);
}
}