From a6b8513096570a42cd857cf7617cc2bb1bd9d96f Mon Sep 17 00:00:00 2001 From: Peter Wemm Date: Wed, 1 Mar 2000 19:30:36 +0000 Subject: [PATCH] Don't free(sc) before returning an error from probe, it does not "belong" to us, subr_bus.c will free it. This bug (panic: freeing already free) was exposed by kern/subr_bus.c rev 1.54 Not explicitly approved by: jkh (but this is a showstopper and fallout of the above approved change) --- sys/dev/atkbdc/psm.c | 1 - sys/isa/psm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/sys/dev/atkbdc/psm.c b/sys/dev/atkbdc/psm.c index f2a4d91badc..e702d0492d6 100644 --- a/sys/dev/atkbdc/psm.c +++ b/sys/dev/atkbdc/psm.c @@ -765,7 +765,6 @@ doopen(int unit, int command_byte) --verbose; \ kbdc_set_device_mask(sc->kbdc, mask); \ kbdc_lock(sc->kbdc, FALSE); \ - free(sc, M_DEVBUF); \ return (v); \ } diff --git a/sys/isa/psm.c b/sys/isa/psm.c index f2a4d91badc..e702d0492d6 100644 --- a/sys/isa/psm.c +++ b/sys/isa/psm.c @@ -765,7 +765,6 @@ doopen(int unit, int command_byte) --verbose; \ kbdc_set_device_mask(sc->kbdc, mask); \ kbdc_lock(sc->kbdc, FALSE); \ - free(sc, M_DEVBUF); \ return (v); \ }