From a4bf2e2d49c5d075f09cca690487a6ac8240edb3 Mon Sep 17 00:00:00 2001 From: "Pedro F. Giffuni" Date: Sat, 9 Jul 2016 02:33:45 +0000 Subject: [PATCH] ng_mppc(4):: basic readability cleanups. In particular use __unreachable() to appease static analyzers. No functional change. CID: 1356591 MFC after: 3 days --- sys/net/mppcc.c | 3 ++- sys/net/mppcd.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/net/mppcc.c b/sys/net/mppcc.c index 01ce3ff4488..8ec21ad7c65 100644 --- a/sys/net/mppcc.c +++ b/sys/net/mppcc.c @@ -232,8 +232,9 @@ int MPPC_Compress(u_char **src, u_char **dst, u_long *srcCnt, u_long *dstCnt, ch } else if (off < 8192) { /* 16-bit offset; 320 <= offset < 8192 */ putbits16(*dst, 0xc000|(off-320), 16, &olen, &l); } else { /* NOTREACHED */ + __unreachable(); rtn &= ~MPPC_OK; - return rtn; + return (rtn); } /* Encode length of match. */ diff --git a/sys/net/mppcd.c b/sys/net/mppcd.c index c1730e55b1b..d8e663c8989 100644 --- a/sys/net/mppcd.c +++ b/sys/net/mppcd.c @@ -170,7 +170,7 @@ int MPPC_Decompress(u_char **src, u_char **dst, u_long *srcCnt, u_long *dstCnt, rtn &= ~MPPC_OK; return (rtn); } - } else { /* NOTREACHED */ + } else { /* This shouldn't happen. */ rtn &= ~MPPC_OK; return (rtn); }