upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-29 02:13:01 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

gpiobus: gpiobus_release_pin: convert errors to panic

Browse source 
These are programming errors.

Suggested by:	mmel
Reviewed by:	imp
Approved by:	imp (mentor)
Differential Revision:	https://reviews.freebsd.org/D50939
This commit is contained in:
Ahmad Khalifa 2025-07-04 23:01:29 +03:00
parent ed50879c4a
commit a2bfb7cff2
2 changed files with 9 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
sys/dev/gpio/gpiobus.c
View file

@ -415,7 +415,7 @@ gpiobus_acquire_pin(device_t bus, uint32_t pin)
}
/* Release mapped pin */
int
void
gpiobus_release_pin(device_t bus, uint32_t pin)
{
struct gpiobus_softc *sc;
@ -423,19 +423,15 @@ gpiobus_release_pin(device_t bus, uint32_t pin)
sc = device_get_softc(bus);
/* Consistency check. */
if (pin >= sc->sc_npins) {
device_printf(bus,
"invalid pin %d, max=%d\n",
pin, sc->sc_npins - 1);
return (-1);
panic("%s: invalid pin %d, max: %d",
device_get_nameunit(bus), pin, sc->sc_npins - 1);
}
if (!sc->sc_pins[pin].mapped) {
device_printf(bus, "pin %d is not mapped\n", pin);
return (-1);
}
if (!sc->sc_pins[pin].mapped)
panic("%s: pin %d is not mapped", device_get_nameunit(bus),
pin);
sc->sc_pins[pin].mapped = 0;
return (0);
}
static int
@ -450,8 +446,7 @@ gpiobus_acquire_child_pins(device_t dev, device_t child)
device_printf(child, "cannot acquire pin %d\n",
devi->pins[i]);
while (--i >= 0) {
(void)gpiobus_release_pin(dev,
devi->pins[i]);
gpiobus_release_pin(dev, devi->pins[i]);
}
gpiobus_free_ivars(devi);
return (EBUSY);

2
sys/dev/gpio/gpiobusvar.h
View file

@ -182,7 +182,7 @@ int gpiobus_alloc_ivars(struct gpiobus_ivar *);
void gpiobus_free_ivars(struct gpiobus_ivar *);
int gpiobus_read_ivar(device_t, device_t, int, uintptr_t *);
int gpiobus_acquire_pin(device_t, uint32_t);
int gpiobus_release_pin(device_t, uint32_t);
void gpiobus_release_pin(device_t, uint32_t);
extern driver_t gpiobus_driver;