From 9d85dfae1e8f79ce7073f8520f7ee6b25442fad2 Mon Sep 17 00:00:00 2001 From: Ed Maste Date: Mon, 7 Oct 2013 16:45:16 +0000 Subject: [PATCH] Fix resource leaks Found by: Coverity Scan, CID 1016673, 1007118 Approved by: re --- sbin/camcontrol/fwdownload.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sbin/camcontrol/fwdownload.c b/sbin/camcontrol/fwdownload.c index 7e57d320772..181c2344a63 100644 --- a/sbin/camcontrol/fwdownload.c +++ b/sbin/camcontrol/fwdownload.c @@ -224,6 +224,7 @@ fw_read_img(const char *fw_img_path, const struct fw_vendor *vp, int *num_bytes) goto bailout; } *num_bytes = img_size; + close(fd); return (buf); bailout: free(buf); @@ -286,6 +287,7 @@ fw_download_img(struct cam_device *cam_dev, const struct fw_vendor *vp, ata_28bit_cmd(&ccb->ataio, ATA_ATA_IDENTIFY, 0, 0, 0); } else { warnx("weird disk type '%s'", type); + cam_freeccb(ccb); return 1; } /* Disable freezing the device queue. */