upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

r336028 changed next_msg to a char * from char [] of fixed size. Change

Browse source 
2nd argument of vsnprintf() to get the strlen of next_msg so that the
appropriate size is used.

Found with gcc.

/usr.bin/top/display.c: In function 'new_message':
/usr.bin/top/display.c:963:31: error:
argument to 'sizeof' in 'vsnprintf' call is the same expression as the
destination; did you mean to provide an explicit length?
[-Werror=sizeof-pointer-memaccess]
     vsnprintf(next_msg, sizeof(next_msg), msgfmt, args);

Reviewed by:	daichi
This commit is contained in:
Sean Bruno 2018-07-06 13:22:44 +00:00
parent 32f0fefc39
commit 9d5352cb63
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
usr.bin/top/display.c
View file

@ -960,7 +960,7 @@ new_message(int type, const char *msgfmt, ...)
va_start(args, msgfmt);
/* first, format the message */
vsnprintf(next_msg, sizeof(next_msg), msgfmt, args);
vsnprintf(next_msg, strlen(next_msg), msgfmt, args);
va_end(args);