From 9d433cb875e9540b072d3fb200f32b364e18cf40 Mon Sep 17 00:00:00 2001 From: Allan Jude Date: Thu, 23 Apr 2020 20:14:59 +0000 Subject: [PATCH] trim(8): candelete() returns wrong results because fd is opened O_WRONLY This was discovered while using trim(8) to test bhyve trim Reviewed by: asomers Differential Revision: https://reviews.freebsd.org/D24371 --- usr.sbin/trim/trim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/trim/trim.c b/usr.sbin/trim/trim.c index da332ca81e5..a368f3ac799 100644 --- a/usr.sbin/trim/trim.c +++ b/usr.sbin/trim/trim.c @@ -220,7 +220,7 @@ trim(const char *path, off_t offset, off_t length, bool dryrun, bool verbose) return (0); } - fd = opendev(path, O_WRONLY | O_DIRECT); + fd = opendev(path, O_RDWR | O_DIRECT); arg[0] = offset; arg[1] = length;