upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove NULL checks after M_WAITOK allocations, which - by definition - can

Browse source 
never return NULL.

Reviewed by:	arybchik@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D5773
This commit is contained in:
Edward Tomasz Napierala 2016-03-31 13:20:02 +00:00
parent 316e15b4cc
commit 9b0488ed2a
2 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys/dev/sfxge/sfxge_mcdi.c
View file

@ -250,10 +250,6 @@ sfxge_mcdi_ioctl(struct sfxge_softc *sc, sfxge_ioc_t *ip)
}
mcdibuf = malloc(SFXGE_MCDI_MAX_PAYLOAD, M_TEMP, M_WAITOK | M_ZERO);
if (mcdibuf == NULL) {
rc = ENOMEM;
goto fail4;
}
if ((rc = copyin(ip->u.mcdi.payload, mcdibuf, ip->u.mcdi.len)) != 0) {
goto fail5;
}
@ -292,7 +288,6 @@ sfxge_mcdi_ioctl(struct sfxge_softc *sc, sfxge_ioc_t *ip)
fail6:
fail5:
free(mcdibuf, M_TEMP);
fail4:
fail3:
fail2:
fail1:

5
sys/dev/sfxge/sfxge_nvram.c
View file

@ -75,10 +75,6 @@ sfxge_nvram_rw(struct sfxge_softc *sc, sfxge_ioc_t *ip, efx_nvram_type_t type,
goto fail1;
buf = malloc(chunk_size, M_TEMP, M_WAITOK);
if (buf == NULL) {
rc = ENOMEM;
goto fail2;
}
off = 0;
while (total_size) {
@ -108,7 +104,6 @@ sfxge_nvram_rw(struct sfxge_softc *sc, sfxge_ioc_t *ip, efx_nvram_type_t type,
fail3:
free(buf, M_TEMP);
fail2:
efx_nvram_rw_finish(enp, type);
fail1:
return (rc);