upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-04 14:26:03 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

mlx5(4): only detach IOV children if iov was successfully initialized

Browse source 
Reported by:	jwd
Sponsored by:	NVidia networking
MFC after:	1 week
This commit is contained in:
Konstantin Belousov 2023-12-29 05:14:56 +02:00
parent 069ac18495
commit 987446fa39
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/dev/mlx5/driver.h
View file

@ -736,6 +736,8 @@ struct mlx5_core_dev {
bool dump_copyout;
struct mtx dump_lock;
bool iov_pf;
struct sysctl_ctx_list sysctl_ctx;
int msix_eqvec;
int pwr_status;

11
sys/dev/mlx5/mlx5_core/mlx5_main.c
View file

@ -1719,7 +1719,9 @@ static int init_one(struct pci_dev *pdev,
pci_iov_schema_add_uint64(vf_schema, iov_port_guid_name,
0, 0);
err = pci_iov_attach(bsddev, pf_schema, vf_schema);
if (err != 0) {
if (err == 0) {
dev->iov_pf = true;
} else {
device_printf(bsddev,
"Failed to initialize SR-IOV support, error %d\n",
err);
@ -1753,8 +1755,11 @@ static void remove_one(struct pci_dev *pdev)
struct mlx5_priv *priv = &dev->priv;
#ifdef PCI_IOV
pci_iov_detach(pdev->dev.bsddev);
mlx5_eswitch_disable_sriov(priv->eswitch);
if (dev->iov_pf) {
pci_iov_detach(pdev->dev.bsddev);
mlx5_eswitch_disable_sriov(priv->eswitch);
dev->iov_pf = false;
}
#endif
if (mlx5_unload_one(dev, priv, true)) {