upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 08:43:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

libkern: strdup.c, strndup.c: Prefer memcpy() over bcopy()

Browse source 
The newly allocated memory can not overlap with the string if the string
is properly null-terminated or the maxlen is a valid lengh, i.e no out
of bounds reads. Prefer memcpy() over memmove(), aka bcopy(), for slight
performance gain.

No functional change intended.

Reviewed by:	kib
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D49026
This commit is contained in:
Zhenlei Huang 2025-02-17 23:37:59 +08:00
parent 408394185f
commit 90a3b6a7a4
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/libkern/strdup.c
View file

@ -46,7 +46,7 @@ strdup_flags(const char *string, struct malloc_type *type, int flags)
copy = malloc(len, type, flags);
if (copy == NULL)
return (NULL);
bcopy(string, copy, len);
memcpy(copy, string, len);
return (copy);
}

2
sys/libkern/strndup.c
View file

@ -42,7 +42,7 @@ strndup(const char *string, size_t maxlen, struct malloc_type *type)
len = strnlen(string, maxlen) + 1;
copy = malloc(len, type, M_WAITOK);
bcopy(string, copy, len);
memcpy(copy, string, len);
copy[len - 1] = '\0';
return (copy);
}