upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't free fnamebuf before we calling cfgfile_add(). This changes a

Browse source 
use-after-free error into a minor memory leak.

Reported by:	Coverity
CID:		1006084
This commit is contained in:
Don Lewis 2016-05-16 04:39:16 +00:00
parent b3e348206c
commit 8f2c79ef85
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
usr.sbin/config/lang.l
View file

@ -267,7 +267,8 @@ include(const char *fname, int ateof)
asprintf(&fnamebuf, "../../conf/%s", fname);
if (fnamebuf != NULL) {
fp = fopen(fnamebuf, "r");
free(fnamebuf);
if (fp == NULL)
free(fnamebuf);
}
}
if (fp == NULL) {
@ -275,10 +276,10 @@ include(const char *fname, int ateof)
asprintf(&fnamebuf, "%s/%s", ipath->path, fname);
if (fnamebuf != NULL) {
fp = fopen(fnamebuf, "r");
free(fnamebuf);
}
if (fp != NULL)
break;
free(fnamebuf);
}
}
if (fp == NULL) {