upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-02-19 02:30:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

sys: Mark ACL conversion routines as __result_use_check

Browse source 
Both acl_copy_oldacl_into_acl() and acl_copy_acl_into_oldacl() may fail
in some circumstances (e.g., acl.acl_cnt exceeding the capacity of
OLDACL_MAX_ENTRIES).  This change marks both routines with
__result_use_check, enforcing check for errors by the caller.

Suggested by:	markj
Reviewed by:	markj, emaste
Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D46254

(cherry picked from commit ef9fc9609a1ff53047577aa7cf51246fc04c954b)
This commit is contained in:
Pierre Pronchery 2024-08-09 19:37:38 +02:00 committed by Ed Maste
parent ab7a79806e
commit 82fd921975
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sys/sys/acl.h
View file

@ -307,9 +307,9 @@ void acl_nfs4_compute_inherited_acl(
const struct acl *parent_aclp,
struct acl *child_aclp, mode_t mode,
int file_owner_id, int is_directory);
int acl_copy_oldacl_into_acl(const struct oldacl *source,
int __result_use_check acl_copy_oldacl_into_acl(const struct oldacl *source,
struct acl *dest);
int acl_copy_acl_into_oldacl(const struct acl *source,
int __result_use_check acl_copy_acl_into_oldacl(const struct acl *source,
struct oldacl *dest);
/*