upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

netinet: Fix getcred sysctl handlers to do nothing if no input is given

Browse source 
These routines were all assuming that the sysctl handler has some new
value, but this is not the case.  SYSCTL_IN() returns 0 in this
scenario, so they were all operating on an uninitialized address.  This
is mostly harmless, but trips KMSAN checks, so let's fix them.

Reviewed by:	zlei, rrs, glebius
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D49348

(cherry picked from commit 3ff865c6a7948b2cfc01d7056c619145b696700a)
This commit is contained in:
Mark Johnston 2025-03-20 01:33:44 +00:00 committed by Franco Fichtner
parent e0b3614769
commit 801c84ae95
5 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sys/netinet/sctp_usrreq.c
View file

@ -361,8 +361,9 @@ sctp_getcred(SYSCTL_HANDLER_ARGS)
/* FIX, for non-bsd is this right? */
vrf_id = SCTP_DEFAULT_VRFID;
if (req->newptr == NULL)
return (EINVAL);
error = priv_check(req->td, PRIV_NETINET_GETCRED);
if (error)
return (error);

4
sys/netinet/tcp_subr.c
View file

@ -2751,6 +2751,8 @@ tcp_getcred(SYSCTL_HANDLER_ARGS)
struct inpcb *inp;
int error;
if (req->newptr == NULL)
return (EINVAL);
error = priv_check(req->td, PRIV_NETINET_GETCRED);
if (error)
return (error);
@ -2793,6 +2795,8 @@ tcp6_getcred(SYSCTL_HANDLER_ARGS)
int mapped = 0;
#endif
if (req->newptr == NULL)
return (EINVAL);
error = priv_check(req->td, PRIV_NETINET_GETCRED);
if (error)
return (error);

2
sys/netinet/udp_usrreq.c
View file

@ -820,6 +820,8 @@ udp_getcred(SYSCTL_HANDLER_ARGS)
struct inpcb *inp;
int error;
if (req->newptr == NULL)
return (EINVAL);
error = priv_check(req->td, PRIV_NETINET_GETCRED);
if (error)
return (error);

2
sys/netinet6/sctp6_usrreq.c
View file

@ -375,6 +375,8 @@ sctp6_getcred(SYSCTL_HANDLER_ARGS)
vrf_id = SCTP_DEFAULT_VRFID;
if (req->newptr == NULL)
return (EINVAL);
error = priv_check(req->td, PRIV_NETINET_GETCRED);
if (error)
return (error);

2
sys/netinet6/udp6_usrreq.c
View file

@ -609,6 +609,8 @@ udp6_getcred(SYSCTL_HANDLER_ARGS)
struct inpcb *inp;
int error;
if (req->newptr == NULL)
return (EINVAL);
error = priv_check(req->td, PRIV_NETINET_GETCRED);
if (error)
return (error);