upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-12 18:20:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tcp rack: fix sending

Browse source 
In rack_output(), idle is used as a boolean variable. So don't use it
as an int and don't clear it afterwards.
This avoids setting idle to false, when it is not intended.

Reported by:		olivier
Reviewed by:		rrs, rscheff
MFC after:		3 days
Sponsored by:		Netflix, Inc.
Differential Revision:	https://reviews.freebsd.org/D44610
This commit is contained in:
Michael Tuexen 2024-04-05 17:47:03 +02:00
parent aaabed1dea
commit 7df0ef5f48
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sys/netinet/tcp_stacks/rack.c
View file

@ -21283,7 +21283,8 @@ rack_output(struct tcpcb *tp)
unsigned ipsec_optlen = 0;
#endif
int32_t idle, sendalot, tot_idle;
int32_t idle, sendalot;
uint32_t tot_idle;
int32_t sub_from_prr = 0;
volatile int32_t sack_rxmit;
struct rack_sendmap *rsm = NULL;
@ -21525,8 +21526,8 @@ rack_output(struct tcpcb *tp)
if ((tp->snd_una == tp->snd_max) &&
rack->r_ctl.rc_went_idle_time &&
(cts > rack->r_ctl.rc_went_idle_time)) {
tot_idle = idle = (cts - rack->r_ctl.rc_went_idle_time);
if (idle > (uint64_t)rack_min_probertt_hold) {
tot_idle = (cts - rack->r_ctl.rc_went_idle_time);
if (tot_idle > rack_min_probertt_hold) {
/* Count as a probe rtt */
if (rack->in_probe_rtt == 0) {
rack->r_ctl.rc_lower_rtt_us_cts = cts;
@ -21537,7 +21538,6 @@ rack_output(struct tcpcb *tp)
rack_exit_probertt(rack, cts);
}
}
idle = 0;
}
if(rack->policer_detect_on) {
/*