upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 00:32:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "sbin/ping: allow normal users to specify larger packets"

Browse source 
It is causing test failures.

This reverts commit 80a5b26871.
This commit is contained in:
Pedro F. Giffuni 2024-10-16 00:21:30 -05:00
parent 42b7e9c4a9
commit 7bc0cb91a2
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sbin/ping/ping.8
View file

@ -25,7 +25,7 @@
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE.
.\"
.Dd October 15, 2024
.Dd September 15, 2023
.Dt PING 8
.Os
.Sh NAME
@ -312,6 +312,7 @@ with the 8 bytes of
ICMP
header data.
.Pp
For IPv4, only the super-user may specify values more than default.
This option cannot be used with ping sweeps.
.Pp
For IPv6, you may need to specify

11
sbin/ping/ping.c
View file

@ -96,8 +96,8 @@
#define DEFDATALEN 56 /* default data length */
#define FLOOD_BACKOFF 20000 /* usecs to back off if F_FLOOD mode */
/* runs out of buffer space */
#define MAXIPLEN ((int)sizeof(struct ip) + MAX_IPOPTLEN)
#define MAXPAYLOAD (IP_MAXPACKET - MAXIPLEN - ICMP_MINLEN)
#define MAXIPLEN (sizeof(struct ip) + MAX_IPOPTLEN)
#define MAXICMPLEN (ICMP_ADVLENMIN + MAX_IPOPTLEN)
#define MAXWAIT 10000 /* max ms to wait for response */
#define MAXALARM (60 * 60) /* max seconds for alarm timeout */
#define MAXTOS 255
@ -458,10 +458,11 @@ ping(int argc, char *const *argv)
errx(EX_USAGE, "invalid packet size: `%s'",
optarg);
datalen = (int)ltmp;
if (datalen > MAXPAYLOAD) {
errx(EX_USAGE,
if (uid != 0 && datalen > DEFDATALEN) {
errno = EPERM;
err(EX_NOPERM,
"packet size too large: %d > %u",
datalen, MAXPAYLOAD);
datalen, DEFDATALEN);
}
break;
case 'T': /* multicast TTL */