upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-04-20 21:59:20 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Consistently use ifaddr_byindex() to access the link-level address

Browse source 
of an interface. No functional change.

On passing, comment an useless invocation of TAILQ_INIT(&ifp->if_addrhead)
which could probably be removed in the interest of clarity.
This commit is contained in:
Luigi Rizzo 2004-04-16 08:15:37 +00:00
parent 9b98ee2c4f
commit 7affdebea2
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sys/netgraph/ng_fec.c
View file

@ -375,7 +375,7 @@ ng_fec_addport(struct ng_fec_private *priv, char *iface)
* by extension, all the other ports in the bundle).
*/
if (b->fec_ifcnt == 0) {
ifa = TAILQ_FIRST(&ifp->if_addrhead);
ifa = ifaddr_byindex(ifp->if_index);
sdl = (struct sockaddr_dl *)ifa->ifa_addr;
bcopy((char *)ac->ac_enaddr,
priv->arpcom.ac_enaddr, ETHER_ADDR_LEN);
@ -392,7 +392,7 @@ ng_fec_addport(struct ng_fec_private *priv, char *iface)
(char *)&new->fec_mac, ETHER_ADDR_LEN);
/* Set up phony MAC address. */
ifa = TAILQ_FIRST(&bifp->if_addrhead);
ifa = ifaddr_byindex(bifp->if_index);
sdl = (struct sockaddr_dl *)ifa->ifa_addr;
bcopy(priv->arpcom.ac_enaddr, ac->ac_enaddr, ETHER_ADDR_LEN);
bcopy(priv->arpcom.ac_enaddr, LLADDR(sdl), ETHER_ADDR_LEN);
@ -451,7 +451,7 @@ ng_fec_delport(struct ng_fec_private *priv, char *iface)
/* Restore MAC address. */
ac = (struct arpcom *)bifp;
ifa = TAILQ_FIRST(&bifp->if_addrhead);
ifa = ifaddr_byindex(bifp->if_index);
sdl = (struct sockaddr_dl *)ifa->ifa_addr;
bcopy((char *)&p->fec_mac, ac->ac_enaddr, ETHER_ADDR_LEN);
bcopy((char *)&p->fec_mac, LLADDR(sdl), ETHER_ADDR_LEN);
@ -1090,7 +1090,7 @@ ng_fec_constructor(node_p node)
ifp->if_addrlen = 0; /* XXX */
ifp->if_hdrlen = 0; /* XXX */
ifp->if_baudrate = 100000000; /* XXX */
TAILQ_INIT(&ifp->if_addrhead);
TAILQ_INIT(&ifp->if_addrhead); /* XXX useless - done in if_attach */
/* Give this node the same name as the interface (if possible) */
bzero(ifname, sizeof(ifname));