upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[bhnd] Fix release of uninitialized SPROM shadow in chipc detach.

Browse source 
This was triggering a panic on detach; the SPROM shadow is now
maintained by the bhnd_sprom_chipc driver, and should be removed
from chipc.

Submitted by:	Landon Fuller <landonf@landonf.org>
Differential Revision:	https://reviews.freebsd.org/D6548
This commit is contained in:
Adrian Chadd 2016-05-26 00:44:16 +00:00
parent 785df0cb3f
commit 72ebcd5db5
2 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
sys/dev/bhnd/cores/chipc/chipc.c
View file

@ -269,7 +269,6 @@ chipc_detach(device_t dev)
chipc_release_region(sc, sc->core_region, RF_ALLOCATED|RF_ACTIVE);
chipc_free_rman(sc);
bhnd_sprom_fini(&sc->sprom);
CHIPC_LOCK_DESTROY(sc);

6
sys/dev/bhnd/cores/chipc/chipcvar.h
View file

@ -186,12 +186,8 @@ struct chipc_softc {
bhnd_nvram_src_t nvram_src; /**< identified NVRAM source */
struct mtx mtx; /**< state mutex. */
struct bhnd_sprom sprom; /**< OTP/SPROM shadow, if any */
size_t sprom_refcnt; /**< SPROM hardware refcount */
size_t sprom_refcnt; /**< SPROM pin enable refcount */
struct rman mem_rman; /**< port memory manager */
STAILQ_HEAD(, chipc_region) mem_regions;/**< memory allocation records */
};