mirror of
https://github.com/opnsense/src.git
synced 2026-05-28 04:12:45 -04:00
Clarify lifetime of child(..) function
Ensure child exits when complete as it's always run in a forked process. Add a missing break statement in :pselect_sigmask when calling child(..) for clarity and to avoid weird domino effects if the child process somehow does something it's not supposed to do with the logfiles, file descriptors, etc MFC after: 1 week Reported by: Coverity CID: 1223369, 1223370, 1300301
This commit is contained in:
parent
f0ab3d3668
commit
7251167f52
1 changed files with 6 additions and 0 deletions
|
|
@ -135,6 +135,9 @@ child(const struct timespec *ts)
|
|||
"after timeout %s != %s",
|
||||
prmask(&nset, nbuf, sizeof(nbuf)),
|
||||
prmask(&oset, obuf, sizeof(obuf)));
|
||||
#ifdef __FreeBSD__
|
||||
_exit(0);
|
||||
#endif
|
||||
}
|
||||
|
||||
ATF_TC(pselect_sigmask);
|
||||
|
|
@ -154,6 +157,9 @@ ATF_TC_BODY(pselect_sigmask, tc)
|
|||
switch (pid = fork()) {
|
||||
case 0:
|
||||
child(NULL);
|
||||
#ifdef __FreeBSD__
|
||||
break;
|
||||
#endif
|
||||
case -1:
|
||||
err(1, "fork");
|
||||
default:
|
||||
|
|
|
|||
Loading…
Reference in a new issue