From 6bea9ab43b92f0e9a94ca208064fd1a3f02c3ca2 Mon Sep 17 00:00:00 2001 From: "Andrey A. Chernov" Date: Tue, 27 Mar 2001 15:53:48 +0000 Subject: [PATCH] Add comment explaining why size not passed directly to mmap, i.e. not relay on its check. KNF multi-line comments (inspired by bde) --- usr.bin/tail/forward.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/usr.bin/tail/forward.c b/usr.bin/tail/forward.c index cfcb535acc3..ef046ccbd74 100644 --- a/usr.bin/tail/forward.c +++ b/usr.bin/tail/forward.c @@ -274,15 +274,21 @@ rlines(fp, off, sbp) if (!(size = sbp->st_size)) return; + /* + * size not passed directly to mmap() below because unclear error + * diagnostic "Invalid argument". + */ if (size > SIZE_T_MAX || size < 0) { errno = EFBIG; ierr(); exit(1); } - /* XXX: FIXME - mmap() not support files over 2Gb */ - /* Large file processing require alternative implementation */ - /* for now print nice error diagnostic at least */ + /* + * XXX: FIXME - mmap() not support files over 2GB + * Large file processing require alternative implementation, + * for now print nice error diagnostic at least. + */ if (size > SSIZE_MAX) { errno = EFBIG; ierr();