upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 00:32:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

netpfil tests: skip checksum verification in pft_ping.py

Browse source 
From scapy 2.6.0 it now removes (sets to None) the IP checksum in its defrag
code. We typically ask for IPv4 or IPv6 defragmentation, which causes check
function failures.

Just skip the checksum verificiation here, because we're going to notice
incorrect checksums even if the tests don't directly verify it.

MFC after:	1 week
Sponsored by:	Rubicon Communications, LLC ("Netgate")
This commit is contained in:
Kristof Provost 2024-10-14 14:57:49 +02:00
parent 1b0e41ddff
commit 6b8096fa5f
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/sys/netpfil/common/pft_ping.py
View file

@ -205,12 +205,6 @@ def check_ipv4(expect_params, packet):
if dst_address and ip.dst != dst_address:
LOGGER.debug(f'Wrong IPv4 destination {ip.dst}, expected {dst_address}')
return False
chksum = ip.chksum
ip.chksum = None
new_chksum = sp.IP(sp.raw(ip)).chksum
if chksum != new_chksum:
LOGGER.debug(f'Wrong IPv4 checksum {chksum}, expected {new_chksum}')
return False
if flags and ip.flags != flags:
LOGGER.debug(f'Wrong IP flags value {ip.flags}, expected {flags}')
return False