upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-04 14:26:03 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fusefs: add more readdir tests for misbehaving servers

Browse source 
Inspired by PR 274268

MFC after:	2 weeks
Sponsored by:	Axcient
This commit is contained in:
Alan Somers 2023-10-05 10:13:05 -06:00
parent b00dbe851c
commit 6a773a0582
1 changed files with 87 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

87
tests/sys/fs/fusefs/readdir.cc
View file

@ -321,6 +321,50 @@ TEST_F(Readdir, nodots)
leakdir(dir);
}
/*
* FUSE_READDIR returns a path with an embedded NUL. Obviously illegal, but
* nothing bad should happen.
*/
TEST_F(Readdir, nul)
{
const char FULLPATH[] = "mountpoint/some_dir";
const char RELPATH[] = "some_dir";
uint64_t ino = 42;
DIR *dir;
struct dirent *de;
vector<struct dirent> ents(1);
vector<struct dirent> empty_ents(0);
const char nul[] = "foo\0bar";
expect_lookup(RELPATH, ino);
expect_opendir(ino);
ents[0].d_fileno = 4;
ents[0].d_off = 4000;
ents[0].d_namlen = sizeof(nul);
ents[0].d_type = DT_REG;
strncpy(ents[0].d_name, nul, ents[0].d_namlen);
expect_readdir(ino, 0, ents);
expect_readdir(ino, 4000, empty_ents);
errno = 0;
dir = opendir(FULLPATH);
ASSERT_NE(nullptr, dir) << strerror(errno);
errno = 0;
de = readdir(dir);
ASSERT_NE(nullptr, de) << strerror(errno);
EXPECT_EQ(4ul, de->d_fileno);
EXPECT_EQ(DT_REG, de->d_type);
EXPECT_EQ(sizeof(nul), de->d_namlen);
EXPECT_EQ(0, strcmp(nul, de->d_name));
ASSERT_EQ(nullptr, readdir(dir));
ASSERT_EQ(0, errno);
leakdir(dir);
}
/* telldir(3) and seekdir(3) should work with fuse */
TEST_F(Readdir, seekdir)
{
@ -397,6 +441,49 @@ TEST_F(Readdir, seekdir)
leakdir(dir);
}
/*
* FUSE_READDIR returns a path with an embedded /. Obviously illegal, but
* nothing bad should happen.
*/
TEST_F(Readdir, slash)
{
const char FULLPATH[] = "mountpoint/some_dir";
const char RELPATH[] = "some_dir";
uint64_t ino = 42;
DIR *dir;
struct dirent *de;
vector<struct dirent> ents(1);
vector<struct dirent> empty_ents(0);
const char foobar[] = "foo/bar";
expect_lookup(RELPATH, ino);
expect_opendir(ino);
ents[0].d_fileno = 4;
ents[0].d_off = 4000;
ents[0].d_namlen = sizeof(foobar);
ents[0].d_type = DT_REG;
strncpy(ents[0].d_name, foobar, ents[0].d_namlen);
expect_readdir(ino, 0, ents);
expect_readdir(ino, 4000, empty_ents);
errno = 0;
dir = opendir(FULLPATH);
ASSERT_NE(nullptr, dir) << strerror(errno);
errno = 0;
de = readdir(dir);
ASSERT_NE(nullptr, de) << strerror(errno);
EXPECT_EQ(4ul, de->d_fileno);
EXPECT_EQ(DT_REG, de->d_type);
EXPECT_EQ(sizeof(foobar), de->d_namlen);
EXPECT_EQ(0, strcmp(foobar, de->d_name));
ASSERT_EQ(nullptr, readdir(dir));
ASSERT_EQ(0, errno);
leakdir(dir);
}
TEST_F(Readdir_7_8, nodots)
{
const char FULLPATH[] = "mountpoint/some_dir";